Skip to content

Conversation

@kevinmarete
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DT-2353

Summary

Adds a React TypeScript component that renders input fields for Clinical Trials based on the defined schema and interface. Includes field-level validation, business logic for input validation, and unit tests.

Add
Add

Edit
Edit

List
List


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@kevinmarete kevinmarete self-assigned this Oct 23, 2025
@kevinmarete kevinmarete marked this pull request as ready for review October 23, 2025 00:41
@kevinmarete kevinmarete requested a review from a team as a code owner October 23, 2025 00:41
@kevinmarete kevinmarete requested review from eweitz and fboulnois and removed request for a team October 23, 2025 00:41
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

Copy link
Member

@eweitz eweitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It'd be helpful to type some of these fields as string enums. Doing that here would be great, but I can also see extracting that to a separate ticket.

@sonarqubecloud
Copy link

@kevinmarete
Copy link
Contributor Author

Updated forms with dropdowns for Status, InterventionType, and Phase

New
New

Edit
Edit

List
List

@kevinmarete kevinmarete requested a review from eweitz October 27, 2025 21:24
Copy link
Member

@eweitz eweitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refinements!

@kevinmarete kevinmarete merged commit a00a71d into develop Oct 28, 2025
11 of 12 checks passed
@kevinmarete kevinmarete deleted the km_DT-2353_clinical_trial_component branch October 28, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants